-
Notifications
You must be signed in to change notification settings - Fork 141
NFR Test Results for NGF version edge #3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed8c4be to
43245fb
Compare
|
TTR images in the scale test were not rendered. We should also remove any unneeded files ourselves. Not sure if we created a ticket to automatically do that? Regardless, it would be nice to get these merged in just to get a new baseline on our main branch. |
I fixed that in my PR for NFR tests, really happy to see reduced error logs for these. Wondering why the image issues happened, but I agree we should merge this for baseline. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3921 +/- ##
==========================================
- Coverage 86.82% 86.79% -0.04%
==========================================
Files 128 128
Lines 16575 16575
Branches 62 62
==========================================
- Hits 14392 14386 -6
- Misses 2004 2009 +5
- Partials 179 180 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
952bc7f to
1a99ec3
Compare
|
Have rebase this manually hopefully pipeline passes and bot is not unhappy |
Update with NFR test results for NGF version edge ["oss","plus"]